Fix to use to_numpy utils for joint velocity and effort in ArticulationController #99
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ArticulationControlleronly converts joint position tensors to NumPy arrays when checking them. As a result, joint velocity and effort remain in their original (e.g. GPU) tensor format, which can lead to unexpected downstream errors when consuming those values in NumPy‐based workflows.This PR simply extends the existing to_numpy utility calls to also cover:
Joint velocity&Joint effortAlthough this repo typically does not accept external PRs per its contribution guidelines, I encountered this minor issue during simulation development and thought the fix would benefit other users. I appreciate your consideration!